Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport Arrow deprecated traverse functions #70

Merged

Conversation

aparkersquare
Copy link
Collaborator

@aparkersquare aparkersquare commented Feb 13, 2024

This back-ports some of the traverse methods deprecated in Arrow.

  • Ior.traverse(f -> Either) and Ior.traverseEither synonym
  • Ior.traverse(f -> Iterable)
  • Ior.traverse(f -> Option) and Ior.traverseOption synonym
  • Map.traverse(f -> Either) and Map.traverseEither synonym
  • Map.traverse(f -> Option) and Map.traverseOption synonym
  • Sequence.traverse(f -> Either) and Sequence.traverseEither synonym
  • Sequence.traverse(f -> Option) and Sequence.traverseOption synonym

Update CHANGELOG to document changes since last release.

Update License to indicate we have taken some code from Arrow.

LICENSE Outdated
Comment on lines 205 to 213
This software includes code from the [Λrrow](https://arrow-kt.io/) library.

Copyright (C) 2017 The Λrrow Authors. Licensed under the Apache License, Version 2.0.

You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0.
Unless required by applicable law or agreed to in writing, software distributed under
the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
either express or implied. See the License for the specific language governing permissions and
limitations under the License.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aparkersquare have you run this by Counsel?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update, @aparkersquare? I feel like this was done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link
Collaborator Author

@aparkersquare aparkersquare May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to include the full Arrow license file. This is probably overkill, but covers the case where any of the code we've used was originally based on another project.

Copy link
Contributor

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all,
It's been a while! Looks good to me 😁

I was just working on my KotlinConf slides, and planning to mention Quiver for people looking for these kind of APIs.

To give you a concrete update here. We're planning to move arrow-2 to main asap, and then I want to do a stable ALPHA/RC release. This could be a good point to start preparing a 2.x release here as well, that way we can get rid of the quiverTraverse workaround, and downstream project will finally be able to get rid of deprecations from 1.x while keeping the APIs.

PS: I'm using the Quiver logo in my slides, I assumed that's fine. Let me know if not please.

LICENSE Outdated
Comment on lines 205 to 213
This software includes code from the [Λrrow](https://arrow-kt.io/) library.

Copyright (C) 2017 The Λrrow Authors. Licensed under the Apache License, Version 2.0.

You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0.
Unless required by applicable law or agreed to in writing, software distributed under
the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
either express or implied. See the License for the specific language governing permissions and
limitations under the License.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@hugomd hugomd mentioned this pull request Apr 23, 2024
@hugomd
Copy link
Member

hugomd commented Apr 23, 2024

To give you a concrete update here. We're planning to move arrow-2 to main asap, and then I want to do a stable ALPHA/RC release. This could be a good point to start preparing a 2.x release here as well, that way we can get rid of the quiverTraverse workaround, and downstream project will finally be able to get rid of deprecations from 1.x while keeping the APIs.

Thanks for the update, this is great to hear! I've created #77 to track a 2.x release.

PS: I'm using the Quiver logo in my slides, I assumed that's fine. Let me know if not please.

That should be fine 👍🏻

@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

@aparkersquare aparkersquare merged commit c85d1bf into main May 21, 2024
3 checks passed
@aparkersquare aparkersquare deleted the aparker/20240213-backport-deprecated-traverse-functions branch May 21, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants